我们什么时候去上海已经讨论完了。

• When we'll go to Shanghai has been discussed.